[no-ci] toolshed: modernize conda_create_for_pathfinder_testing scripts#2013
Open
rwgk wants to merge 1 commit intoNVIDIA:mainfrom
Open
[no-ci] toolshed: modernize conda_create_for_pathfinder_testing scripts#2013rwgk wants to merge 1 commit intoNVIDIA:mainfrom
conda_create_for_pathfinder_testing scripts#2013rwgk wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Bring the bash and PowerShell helpers used to spin up CUDA-pathfinder
test environments into line with how cuda_pathfinder/pyproject.toml is
now organized, and harden them so common shell mistakes surface
immediately.
Highlights:
- Add ``set -euo pipefail`` (bash) and ``Set-StrictMode -Version Latest``
(PowerShell) so unset variables and non-zero exit codes fail loudly.
- Pick the Python version from the CUDA major: ``12.x`` -> 3.12,
``13.x`` -> 3.14. Reject other CUDA majors with a clear error
instead of silently installing 3.13.
- Bash: wrap ``conda activate`` and ``conda install`` in ``set +u`` /
``set -u`` because conda's shims dereference unset variables, which
otherwise abort the script under ``set -u``.
- Realign the conda package lists with the platform-scoped groups in
``cuda_pathfinder/pyproject.toml``:
- Add ``cutlass`` (Linux + Windows) and ``libcusolvermp-dev`` (Linux).
- Drop ``libnvpl-fft-dev`` from the unconditional Linux list and from
Windows entirely.
- On Linux, install ``libnvpl-fft-dev`` only on ``aarch64`` and add
``libcudla-dev`` for the ``cu13``/``aarch64`` combination.
- Drop ``libcublasmp-dev``, ``libcufftmp-dev``, ``libnvshmem3``, and
``libnvshmem-dev`` from the Windows list to match what ``pyproject``
installs there.
- Refresh SPDX copyright to ``2025-2026``.
Co-authored-by: Cursor <cursoragent@cursor.com>
rwgk
added
P1
rparolin
reviewed
May 5, 2026
| ) | ||
|
|
||
| $ErrorActionPreference = "Stop" | ||
| Set-StrictMode -Version Latest |
Collaborator
There was a problem hiding this comment.
It would be good to spell out more what "modernization's" you are doing. I'm not sure what you are modernizing based on the code.
rparolin
reviewed
May 5, 2026
| exit 1 | ||
| fi | ||
|
|
||
| cuda_version="$1" |
Collaborator
There was a problem hiding this comment.
Consider: Refactoring these two scripts into a single python script to reduce maintenance headaches.
rparolin
reviewed
May 5, 2026
|
|
||
| foreach ($cpkg in $cpkgs) { | ||
| Write-Host "CONDA INSTALL: $cpkg" | ||
| conda install -y -c conda-forge $cpkg |
Collaborator
There was a problem hiding this comment.
Consider: Using batch install rather then running the resolve N times.
"This runs the conda solver N times instead of once, which is both much slower and can produce a different (worse) environment than solving all packages together — each install can independently downgrade/upgrade shared deps. A single conda install -y -c conda-forge "${cpkgs[@]}" is faster and more consistent."
rparolin
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizations as used for manually testing changes under PR #1977 (xref issue #1038) with Conda Linux and Windows:
Test results: #1977 (comment)
Separate PR to remove a distraction from the bigger set of changes.